Skip to content

Refactor Vocabulary code#82

Merged
svlandeg merged 17 commits intomainfrom
feat/voc_id
Aug 5, 2025
Merged

Refactor Vocabulary code#82
svlandeg merged 17 commits intomainfrom
feat/voc_id

Conversation

@svlandeg
Copy link
Copy Markdown
Owner

@svlandeg svlandeg commented Aug 1, 2025

  • Code structure refactor: separate files for EntrySourceWidget, Entry and csv_parser.
  • Entry fromJson methods each check their own required fields
  • Fixes Revise Vocabulary.ID #41: the ID is only serialized to JSON for the internal data storage. Should be fine.

@svlandeg
Copy link
Copy Markdown
Owner Author

svlandeg commented Aug 1, 2025

TODO: update/fix tests

@svlandeg svlandeg marked this pull request as ready for review August 5, 2025 16:35
@svlandeg svlandeg merged commit 5850397 into main Aug 5, 2025
1 check passed
@svlandeg svlandeg deleted the feat/voc_id branch August 5, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise Vocabulary.ID

1 participant