Fix #1518 Duplicate External Schema Components#2321
Open
knivram wants to merge 2 commits intoswagger-api:masterfrom
Open
Fix #1518 Duplicate External Schema Components#2321knivram wants to merge 2 commits intoswagger-api:masterfrom
knivram wants to merge 2 commits intoswagger-api:masterfrom
Conversation
knivram
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-parser!
Please fill out the following checklist to help us review your PR efficiently.
Description
Fixes #1518
Resolving nested external schema refs could treat the same target schema as different refs depending on the relative path spelling, which led to duplicate generated models with suffixed names (see added test case).
This change normalizes nested external schema refs through the existing
join(...)path resolution logic inExternalRefProcessorinstead of rebuilding the ref manually.Type of Change
Checklist