Skip to content

Conversation

DavidVogel
Copy link

This pull request enhances the sanitizeUrl utility function to handle URLs with multiple levels of relative paths (such as ../../file.json), ensuring correct path reconstruction. Unit tests have also been added to verify this new behavior.

Description

Improvements to URL sanitization:

  • Updated sanitizeUrl in src/core/utils/url.js to correctly process and reconstruct URLs with multiple ../ segments, supporting cases like ../../file.json and deeper relative paths.

Motivation and Context

Current method only handles up to 1 parent level. This allows an arbitrary number of levels.

Fixes #4107

How Has This Been Tested?

  • Added new test cases in test/unit/core/utils.js to verify that sanitizeUrl correctly handles URLs with two or more ../ segments.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec hyperlink broken with relative spec URL

1 participant