Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Trying to access array offset on value of type null (7.4) #101

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

remicollet
Copy link
Contributor

Without this fix

1) Swaggest\JsonSchema\Tests\PHPUnit\ClassStructure\ClassStructureTest::testAdditionalProperties
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-swaggest-json-schema-0.12.27-1.fc31.remi.x86_64/usr/share/php/Swaggest/JsonSchema/Wrapper.php:108
/dev/shm/BUILDROOT/php-swaggest-json-schema-0.12.27-1.fc31.remi.x86_64/usr/share/php/Swaggest/JsonSchema/Structure/ClassStructureTrait.php:161
/dev/shm/BUILD/php-json-schema-9ec863a05a40e9b4547bc0c43dc6992cf17307a3/tests/src/PHPUnit/ClassStructure/ClassStructureTest.php:102

2) Swaggest\JsonSchema\Tests\PHPUnit\ClassStructure\ClassStructureTest::testPatternProperties
Trying to access array offset on value of type null

/dev/shm/BUILDROOT/php-swaggest-json-schema-0.12.27-1.fc31.remi.x86_64/usr/share/php/Swaggest/JsonSchema/Wrapper.php:108
/dev/shm/BUILDROOT/php-swaggest-json-schema-0.12.27-1.fc31.remi.x86_64/usr/share/php/Swaggest/JsonSchema/Structure/ClassStructureTrait.php:161
/dev/shm/BUILD/php-json-schema-9ec863a05a40e9b4547bc0c43dc6992cf17307a3/tests/src/Helper/SampleProperties.php:43
/dev/shm/BUILD/php-json-schema-9ec863a05a40e9b4547bc0c43dc6992cf17307a3/tests/src/PHPUnit/ClassStructure/ClassStructureTest.php:122


@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #101 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   92.15%   92.27%   +0.12%     
==========================================
  Files          27       27              
  Lines        1619     1619              
==========================================
+ Hits         1492     1494       +2     
+ Misses        127      125       -2
Impacted Files Coverage Δ
src/Wrapper.php 57.62% <100%> (ø) ⬆️
src/MagicMapTrait.php 83.78% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec863a...2d8ed28. Read the comment docs.

@vearutop vearutop merged commit 0c6e753 into swaggest:master Jan 27, 2020
@remicollet remicollet deleted the issue-74 branch January 27, 2020 09:38
@vearutop
Copy link
Member

Thank you, tagged as v0.12.28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants