Fix nullable fields #148
Merged
Fix nullable fields #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 92.41% 92.64% +0.23%
==========================================
Files 27 27
Lines 1688 1687 -1
==========================================
+ Hits 1560 1563 +3
+ Misses 128 124 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Could you rebase or merge latest master in your branch (this should fix CI)? |
|
Ok done |
jpwijbenga
reviewed
Feb 14, 2023
|
I think you're right, though maybe the final behavior is somewhat similar (if not raising a notice). Removing line 110 seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in #147 causes nullable JSON fields not to be exported.
This change should fix that.