Skip to content

deterministic in-order iteration of class variables #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/tap/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -546,8 +546,12 @@ def _get_class_variables(self) -> dict:
class_variables = self._get_from_self_and_super(extract_func=get_class_variables)

# Handle edge-case of source code modification while code is running
variables_to_add = class_variable_names - class_variables.keys()
variables_to_remove = class_variables.keys() - class_variable_names
variables_to_add = (
variable for variable in class_variable_names if variable not in class_variables
)
variables_to_remove = (
variable for variable in class_variables.keys() if variable not in class_variable_names
)

for variable in variables_to_add:
class_variables[variable] = {"comment": ""}
Expand Down