Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #4165

Merged
merged 8 commits into from
Apr 1, 2021
Merged

Cleanup #4165

merged 8 commits into from
Apr 1, 2021

Conversation

Disti4ct
Copy link
Collaborator

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the PR once again

Original issue

#3511

Video / screenshot proof

@sorentobot
Copy link
Collaborator

@Disti4ct Disti4ct changed the title (WIP) Cleanup Cleanup Mar 31, 2021
@sorentobot
Copy link
Collaborator

// Create wallet
btnCreateWallet.addEventListener('click', function () {
redirectionTo('#/createWallet');
btnCreateWallet.addEventListener('click', () => {
Copy link
Collaborator

@iower iower Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed ES5 support - it's out of babel.
Everything else looks OK.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it'll removed in #4069

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

Copy link
Member

@noxonsu noxonsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

наконец то скип заработал

@noxonsu noxonsu merged commit 32989f9 into swaponline:master Apr 1, 2021
@Disti4ct Disti4ct deleted the routing branch April 1, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants