BSC as a new blockchain (without swap) #4261

Disti4ct · 2021-04-22T12:02:04Z

Checklist

I have read the CONTRIBUTING guide
Good naming (as clear and simple as possible)
Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
I tested desktop/mobile resolution
I tested light/dark theme
I tested different languages
I checked the functionality once again (AFFECT MONEY)
I checked the PR once again

Original issue

Думаю лучше поменять тест в FAQ. Более общее описание в части с эфиром и токенами.

Сейчас:

EN

For ERC20 tokens, it is required that you have at least 0.001 ETH on your wallets. Remember! when sending ERC20 tokens, you are required to hold some ETH as miners fees for transactions. This is also the case for all atomic swaps for ETH & ERC20 tokens.

RU

Для токенов ERC20 требуется, чтобы на ваших кошельках было не менее 0,001 ETH. Помнить! при отправке токенов ERC20 вы должны удерживать некоторое количество ETH в качестве комиссии майнеров за транзакции. Это также относится ко всем атомным свопам для токенов ETH и ERC20.

Мой вариант (edited / 0.001 ETH isn't enough yet - the right way is calculation):

EN

To send tokens, you need to have a certain amount in the base currency for the token in your wallet - this is necessary in order to pay miner fees. For example, ERC20 tokens require a small amount of ETH to send, while BEP20 tokens require a small amount of BNB. This also applies to all atomic swaps, which also require paying miner fees.

RU

Для отправки токенов вам необходимо иметь некоторую сумму в базовой для токена валюте в вашем кошельке - это необходимо, чтобы заплатить комиссию майнерам. Например, ERC20-токены требуют небольшого количества ETH для отправки, а BEP20-токены требуют небольшого количества BNB. Это также относится ко всем атомарным свопам, которые также требуют оплаты комиссии майнеров.

Video / screenshot proof

… the balance is not enough

Replace names in the redux store (bnb in the ethData) Fix metamask warning about wrong network Fix for Withdraw modal Change routing paths (doesn't work for Currency wallet) Cleanup: Wallet component, reducers/currency

…Add BNB helpers (it uses eth helpers)

Create additional files for BNB. Fix the provider link in the metamask helper

Delete code dubbing for mnemonic phrase Partial changes for BNB (names, comments and so on)

Fix BNB wallet addition into Redux store

Change externalConfig currency

src/front/config/bsc-testnet/api.js

src/front/shared/redux/actions/bnb.ts

src/common/utils/mnemonic.ts

sorentobot · 2021-05-14T09:54:10Z

commit 70b39c1 rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

sorentobot · 2021-05-14T10:40:21Z

commit 17fdbd3 rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

sorentobot · 2021-05-14T10:56:03Z

commit 0b56b2e rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

sorentobot · 2021-05-14T13:26:05Z

commit 43b0fd3 rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

…nected

shendel · 2021-05-14T14:22:27Z

src/front/shared/helpers/getReduxState.ts

+const getReduxState = () => {
+  const reduxState = getState()
+
+  // Fix user store


сдесь надо добавить проверку по всем типам redux

sorentobot · 2021-05-14T14:30:14Z

commit ade55dc rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

sorentobot · 2021-05-14T15:17:15Z

commit 037df8e rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

sorentobot · 2021-05-14T15:42:19Z

commit 348e9e5 rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

…urrencyWallet into pr/4261

…urrencyWallet into renameEthToBsc

sorentobot · 2021-05-14T16:14:14Z

commit 4ffef8a rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

sorentobot · 2021-05-14T17:40:25Z

commit 646a53a rebuilded https://testnet4261.swaponline.site https://mainnet4261.swaponline.site

Disti4ct · 2021-05-14T17:56:22Z

сначало надо отменить обновление на bsc.swap.io и сделать ветку отдельную для этого домена

Disti4ct added 27 commits March 9, 2021 06:46

Rename config keys

f7ffcfb

Cleanup Coin component

2243550

Minore fix

0ad30d6

Fix conflict

9fb83e3

Fix link validation in the Endpoints

3de2c37

Merge branch 'master' into renameEthToBsc

77d5ee7

Merge branch 'master' into renameEthToBsc

03f720a

Connect modal: UI fix for dark theme. Wallet: add the notification if…

4f043e1

… the balance is not enough

Wrong network modal: UI fix for dark theme

9941471

Merge branch 'master' into renameEthToBsc

b981793

Add BNB to swap.app coins

a4dddcb

Replace names in the redux store (bnb in the ethData) Fix metamask warning about wrong network Fix for Withdraw modal Change routing paths (doesn't work for Currency wallet) Cleanup: Wallet component, reducers/currency

Delete unused code in the Withdraw form. Improve Error notification. …

7a6f7cf

…Add BNB helpers (it uses eth helpers)

Merge branch 'master' into renameEthToBsc

2c5cc43

Don't replace ETH with BNB. Will use it together.

b45f2db

Create additional files for BNB. Fix the provider link in the metamask helper

Merge. Fix conflicts

16942ec

Small changes. Fix request for currency info

f653a7b

Add BNB actions

f7538d1

Delete code dubbing for mnemonic phrase Partial changes for BNB (names, comments and so on)

Add BNB in the Create Wallet component

076bcdb

Fix BNB wallet addition into Redux store

Merge branch 'master' into renameEthToBsc

609464d

Fix wbtc icon display

1dda8a0

Fix withdraw form

733950d

Restore BNB wallet from ETH

1e3c786

Fix fee calculating in the Withdraw form (for BNB)

e90fee0

Change externalConfig currency

Add external configs for bsc

8caa9bb

Fix problem with BNB balance request

e9928be

Merge branch 'master' into renameEthToBsc

147cc43

Correct FAQ display for BNB

d7f39ab

shendel reviewed Apr 22, 2021

View reviewed changes

src/front/config/bsc-testnet/api.js Outdated Show resolved Hide resolved

shendel reviewed Apr 22, 2021

View reviewed changes

src/front/shared/redux/actions/bnb.ts Outdated Show resolved Hide resolved

noxonsu reviewed Apr 22, 2021

View reviewed changes

src/common/utils/mnemonic.ts Outdated Show resolved Hide resolved

Fix BigNumber error when we send tokens

17fdbd3

Fix token sending with float amount

0b56b2e

Improve metamask wallet addition in the helpers

43b0fd3

Localisation cleanup. Show metamask icon if external wallet is discon…

ade55dc

…nected

shendel reviewed May 14, 2021

View reviewed changes

Fix metamask title link in the Wallet row

037df8e

Delete BSC configs, scripts

348e9e5

shendel and others added 5 commits May 14, 2021 18:52

wp - disable bsc builds

d1d1cc4

Merge branch 'renameEthToBsc' of https://github.com/NotEternal/MultiC…

307fa4d

…urrencyWallet into pr/4261

wp - rm bsc folders from repo

89fb923

Merge branch 'master' into renameEthToBsc

47f2a16

Merge branch 'renameEthToBsc' of https://github.com/NotEternal/MultiC…

4ffef8a

…urrencyWallet into renameEthToBsc

shendel approved these changes May 14, 2021

View reviewed changes

Fix widget app creation

646a53a

Disti4ct changed the title ~~(WIP) Binance integration~~ Binance integration May 14, 2021

Disti4ct changed the title ~~Binance integration~~ (WIP) Binance integration May 14, 2021

noxonsu merged commit b2f2b7a into swaponline:master May 14, 2021

noxonsu changed the title ~~(WIP) Binance integration~~ BSC as a new blockchain (without swap) May 14, 2021

Disti4ct deleted the renameEthToBsc branch May 16, 2021 06:21

Disti4ct mentioned this pull request Jun 3, 2021

new network: add polygon (matic) to wallet and swap #4448

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BSC as a new blockchain (without swap) #4261

BSC as a new blockchain (without swap) #4261

Disti4ct commented Apr 22, 2021 •

edited

Loading

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

shendel May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

Disti4ct commented May 14, 2021

BSC as a new blockchain (without swap) #4261

BSC as a new blockchain (without swap) #4261

Conversation

Disti4ct commented Apr 22, 2021 • edited Loading

Checklist

Original issue

Думаю лучше поменять тест в FAQ. Более общее описание в части с эфиром и токенами.

Сейчас:

Мой вариант (edited / 0.001 ETH isn't enough yet - the right way is calculation):

Video / screenshot proof

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

shendel May 14, 2021

Choose a reason for hiding this comment

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

sorentobot commented May 14, 2021

Disti4ct commented May 14, 2021

Disti4ct commented Apr 22, 2021 •

edited

Loading