Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw form: can't withdraw tokens. Cleanup #4918

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Withdraw form: can't withdraw tokens. Cleanup #4918

merged 6 commits into from
Nov 18, 2021

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented Nov 18, 2021 •
edited
Loading

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

#4912
#3511

Video / screenshot proof

Before

o2p3g4u

After

after

@noxonsu noxonsu added the withdraw tests this label starts some withdraw tests if it added for the pull request label Nov 18, 2021
@Disti4ct Disti4ct marked this pull request as ready for review November 18, 2021 10:59
@Disti4ct Disti4ct added withdraw tests this label starts some withdraw tests if it added for the pull request and removed withdraw tests this label starts some withdraw tests if it added for the pull request labels Nov 18, 2021
@Disti4ct Disti4ct added withdraw tests this label starts some withdraw tests if it added for the pull request needs review and removed withdraw tests this label starts some withdraw tests if it added for the pull request labels Nov 18, 2021
@noxonsu noxonsu merged commit bbc9f30 into master Nov 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the withdrawFormProblems branch November 18, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noxonsu noxonsu noxonsu approved these changes

@VitaliyShulik VitaliyShulik Awaiting requested review from VitaliyShulik

Assignees
No one assigned
Labels
needs review withdraw tests this label starts some withdraw tests if it added for the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Disti4ct @noxonsu