sway/commands/move.c: negative coords move to the bottom/right edge#9058
sway/commands/move.c: negative coords move to the bottom/right edge#9058cizra wants to merge 1 commit into
Conversation
|
Who do I ping to get this reviewed? Let's randomly pick @emersion as the author of a recent commit - would you know who to ping? |
|
Is this something i3 does, or is this a new feature? |
|
@emersion I've no idea, I haven't used i3 almost at all. |
|
Outputs can be placed at negative positions and a negative move position would be valid in that case, which this PR would break. Even with all outputs at non-negative positions, someone may want to move to a negative position to position the window slightly off-screen, which this PR would break.
Parse |
|
@Arnavion thanks for the insightful comments. How would I implement your suggestion? I would prefer not to change it to a daemon listening to events and moving windows around - it'd be an external system to manage, and it'd possibly introduce some flicker, if the window gets drawn somewhere, then moved elsewhere. Would it be better to create a new command, movebr (for move-bottom-right) with this calculation logic? |
|
I, too, would like some feature very similar to this, as I have floating windows I want to place near the bottom/right of my display, and doing a round trip to an external executable to do the position computation and then back to sway with swaymsg seems much more cumbersome in addition to the drawbacks @cizra lists. After all, both Xwindows geometry specifications ( Please could a maintainer provide guidance on a design for this type of feature that would be acceptable? (And @cizra I am happy then to help with implementation if you would like.) Personally, I would suggest that the options need to be independent for vertical and horizontal positioning; one might want to put a window in the top right or bottom left corners as well. Therefore I would suggest that the possibility of keywords
where either the keyword Would revising this PR to implement this suggested syntax allow it to go on to further review? Or is there a different forum that would be preferable to the PR queue for proposing such a feature and having it approved for implementation? Thanks so much for guidance. |
|
@gwhitney LGTM |
Add a possibility to move a window to the bottom or right edge.
Sample config, tested and working: