enable multi-key modifier with floating_modifier#9135
Closed
carpetoctopus wants to merge 3 commits into
Closed
Conversation
Allows using key combinations as the modifier key used for floating_modifier. Example: floating_modifier Shift+Alt normal will work, whereas before it would throw an "Invalid modifier" error.
This commit makes it possible to include the same config file multiple times.
Author
|
It introduces some bugs so I am closing for now. |
Author
|
See #9137 instead, I think it's a better approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows a key combination to be used as the modifier for floating_modifier.
Example:
floating_modifier Shift+Alt normal
will work, whereas before it would throw an "Invalid modifier" error.