fix(formatjs): Variable evaluate concatenation

.cargo/config.toml

@@ -28,7 +28,7 @@ rustflags = ["-C", "target-feature=-crt-static", "-C", "link-arg=-lgcc"]
 [target.armv7-unknown-linux-gnueabihf]
 linker = "arm-linux-gnueabihf-gcc"
 
-# We have not adapt this cfg for swc_ecma_minifier, which styled_jsx depends on.
+# We have not adapt this cfg for swc_ecma_minifier, which styled_jsx and formatjs depends on.
 # So we have to manually enable it for all crates except styled jsx.
 # [target.'cfg(target_arch = "wasm32")']
 # rustflags = [

.github/workflows/CI.yml

@@ -78,8 +78,9 @@ jobs:
       - name: Run cargo check
         env: 
           RUSTFLAGS: "--cfg swc_ast_unknown"
-        run: |
+        run: >
           cargo check --workspace --exclude swc_plugin_styled_jsx --exclude styled_jsx
+          --exclude swc_plugin_formatjs --exclude swc_formatjs_transform
 
   cargo-test:
     strategy:

packages/formatjs/Cargo.toml

@@ -21,4 +21,5 @@ swc_core = { workspace = true, features = [
   "ecma_plugin_transform",
   "ecma_ast_serde",
 ] }
+swc_ecma_minifier = { workspace = true }
 swc_formatjs_transform = { path = "./transform" }

packages/formatjs/__tests__/__snapshots__/wasm.test.ts.snap

@@ -1,5 +1,30 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
 
+exports[`formatjs swc plugin > should handle statically evaluate-able variables 1`] = `
+"import { defineMessage, formatMessage, FormattedMessage } from 'react-intl';
+var part1 = "Hello";
+var part2 = "world";
+var message = defineMessage({
+    id: "neWvNv",
+    defaultMessage: "Helloworld"
+});
+function Greeting() {
+    var message2 = formatMessage({
+        id: "emocAR",
+        defaultMessage: "Helloworld"
+    });
+    var templateMessage = formatMessage({
+        id: "cxaV5O",
+        defaultMessage: "~Hello, world!"
+    });
+    return /*#__PURE__*/ React.createElement(FormattedMessage, {
+        id: "mLV+F/",
+        defaultMessage: "Helloworld"
+    });
+}
+"
+`;
+
 exports[`formatjs swc plugin > should quote plural keys correctly when ast enabled 1`] = `
 "import { formatMessage } from 'react-intl';
 formatMessage({

packages/formatjs/__tests__/wasm.test.ts

@@ -150,6 +150,51 @@ describe("formatjs swc plugin", () => {
     expect(output).not.toMatch(/description/);
   });
 
+  it("should handle statically evaluate-able variables", async () => {
+    const input = `
+      import { defineMessage, formatMessage, FormattedMessage } from 'react-intl';
+
+      const part1 = "Hello";
+      const part2 = "world";
+
+      const message = defineMessage({
+        defaultMessage: part1 + part2,
+        description: "static vars"
+      });
+      function Greeting() {
+        const message2 = formatMessage({
+          defaultMessage: part1 + part2,
+          description: "static vars in function"
+        });
+        const templateMessage = formatMessage({
+          defaultMessage: \`~\${part1}, \${part2}!\`,
+          description: "static string"
+        });
+        return (<FormattedMessage defaultMessage={part1 + part2} />);
+      }
+    `;
+
+    const output = await transformCode(input);
+    expect(output).toMatchSnapshot();
+  });
+
+  it("should throw error on non-statically evaluate-able variables", async () => {
+    const input = `
+      import { defineMessage, formatMessage, FormattedMessage } from 'react-intl';
+
+      const part1 = "Hello, ";
+
+      const message = defineMessage({
+        defaultMessage: part1 + part2,
+        description: "static vars"
+      });
+    `;
+
+    expect(transformCode(input)).rejects.toThrow(
+      "[React Intl] Messages must be statically evaluate-able for extraction.",
+    );
+  });
+
   it("should transform to ast when enabled", async () => {
     const input = `
       import { defineMessage, formatMessage, FormattedMessage } from 'react-intl';

packages/formatjs/package.json

@@ -9,8 +9,8 @@
   "main": "swc_plugin_formatjs.wasm",
   "scripts": {
     "prepack": "pnpm run build",
-    "build": "RUSTFLAGS='--cfg swc_ast_unknown' cargo build --release -p swc_plugin_formatjs --target wasm32-wasip1 && cp ../../target/wasm32-wasip1/release/swc_plugin_formatjs.wasm .",
-    "build:debug": "RUSTFLAGS='--cfg swc_ast_unknown' cargo build -p swc_plugin_formatjs --target wasm32-wasip1 && cp ../../target/wasm32-wasip1/debug/swc_plugin_formatjs.wasm .",
+    "build": "cargo build --release -p swc_plugin_formatjs --target wasm32-wasip1 && cp ../../target/wasm32-wasip1/release/swc_plugin_formatjs.wasm .",
+    "build:debug": "cargo build -p swc_plugin_formatjs --target wasm32-wasip1 && cp ../../target/wasm32-wasip1/debug/swc_plugin_formatjs.wasm .",
     "test": "pnpm run build:debug && vitest run --testTimeout=0"
   },
   "homepage": "https://swc.rs",

packages/formatjs/src/lib.rs

@@ -5,6 +5,7 @@ use swc_core::{
         proxies::TransformPluginProgramMetadata,
     },
 };
+use swc_ecma_minifier::{eval::Evaluator, marks::Marks};
 use swc_formatjs_transform::{create_formatjs_visitor, FormatJSPluginOptions};
 
 #[plugin_transform]
@@ -23,11 +24,14 @@ pub fn process(mut program: Program, metadata: TransformPluginProgramMetadata) -
         Default::default()
     };
 
+    let module = program.as_module().unwrap();
+    let evaluator = &mut Evaluator::new(module.clone(), Marks::new());
     let mut visitor = create_formatjs_visitor(
         std::sync::Arc::new(metadata.source_map),
         metadata.comments.as_ref(),
         plugin_options,
         filename,
+        evaluator,
     );
 
     program.visit_mut_with(&mut visitor);

packages/formatjs/transform/Cargo.toml

@@ -14,17 +14,18 @@ version = "18.0.0"
 custom_transform = []
 
 [dependencies]
-base64ct   = { workspace = true, features = ["alloc"] }
-digest     = { workspace = true }
-hex        = { workspace = true }
-md-5       = { workspace = true }
-once_cell  = { workspace = true }
-regex      = { workspace = true }
-serde      = { workspace = true, features = ["derive"] }
-serde_json = { workspace = true }
-sha1       = { workspace = true }
-sha2       = { workspace = true }
-swc_core   = { workspace = true, features = ["common", "ecma_visit", "ecma_ast"] }
+base64ct          = { workspace = true, features = ["alloc"] }
+digest            = { workspace = true }
+hex               = { workspace = true }
+md-5              = { workspace = true }
+once_cell         = { workspace = true }
+regex             = { workspace = true }
+serde             = { workspace = true, features = ["derive"] }
+serde_json        = { workspace = true }
+sha1              = { workspace = true }
+sha2              = { workspace = true }
+swc_core          = { workspace = true, features = ["common", "ecma_visit", "ecma_ast"] }
+swc_ecma_minifier = { workspace = true }
 
 swc_icu_messageformat_parser = { features = [
   "utf16",