Llvm: Remove -fstack-protector compiler flag [AP-3388]
#149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the LLVM toolchain configuration, the stack protector flag is removed. This feature will emit a warning, if stack protection is not deemed sensible for an array, which is the case for less than 8 bytes of size. If warnings as errors is enabled, this will fail the build, if an array of that size is defined. We are removing the flag for our default builds, as stack protection comes at a small runtime cost and we expect this default toolchain to be used for development purposes only, where stack protection might not be as relevant. Users are encouraged to consider the stricter flags `-fstack-protector-strong` or `-fstack-protector-all` for production builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the LLVM toolchain configuration, the stack protector flag is removed. This feature will emit a warning, if stack protection is not deemed sensible for an array, which is the case for less equal than 8 bytes of size. If warnings as errors is enabled, this will fail the build, if an array of that size is defined.
We are removing the flag for our default builds, as stack protection comes at a small runtime cost, and we expect this default toolchain to be used for development purposes only, where stack protection might not be as relevant.
Users are encouraged to consider the stricter flags
-fstack-protector-strongor-fstack-protector-allfor production builds.