Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String/Int/Double evaluation #20

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Add String/Int/Double evaluation #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
221 changes: 220 additions & 1 deletion IntegrationTests/Tests/Integration/OFREPIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,231 @@ struct OFREPIntegrationTests {
reason: .error,
variant: "a"
)
let flag = "static-a-b"
let flag = "static-a"
await #expect(provider.resolution(of: flag, defaultValue: defaultValue, context: nil) == resolution)
}
}
}

@Suite("String Flag Resolution")
struct StringResolutionTests {
@Test("Static", arguments: [("static-a", "a", "value-a"), ("static-b", "b", "value-b")])
func staticBool(flag: String, variant: String, expectedValue: String) async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: expectedValue,
error: nil,
reason: .static,
variant: variant,
flagMetadata: [:]
)
await #expect(provider.resolution(of: flag, defaultValue: "default", context: nil) == resolution)
}
}

@Test("Targeting Match")
func targetingMatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: "value-b",
error: nil,
reason: .targetingMatch,
variant: "b",
flagMetadata: [:]
)
let flag = "targeting-b"
let context = OpenFeatureEvaluationContext(targetingKey: "swift")
await #expect(provider.resolution(of: flag, defaultValue: "default", context: context) == resolution)
}
}

@Test("No Targeting Match")
func noTargetingMatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: "value-a",
error: nil,
reason: .default,
variant: "a",
flagMetadata: [:]
)
let flag = "targeting-b"
await #expect(provider.resolution(of: flag, defaultValue: "default", context: nil) == resolution)
}
}

@Test("Type mismatch")
func typeMismatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: "default",
error: OpenFeatureResolutionError(
code: .typeMismatch,
message: #"Expected flag value of type "String" but received "Bool"."#
),
reason: .error,
variant: "on"
)
let flag = "static-on"
await #expect(provider.resolution(of: flag, defaultValue: "default", context: nil) == resolution)
}
}
}

@Suite("Int Flag Resolution")
struct IntResolutionTests {
@Test("Static", arguments: [("static-negative-42", "a", -42), ("static-positive-42", "b", 42)])
func staticBool(flag: String, variant: String, expectedValue: Int) async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: expectedValue,
error: nil,
reason: .static,
variant: variant,
flagMetadata: [:]
)
await #expect(provider.resolution(of: flag, defaultValue: 0, context: nil) == resolution)
}
}

@Test("Targeting Match")
func targetingMatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: 42,
error: nil,
reason: .targetingMatch,
variant: "b",
flagMetadata: [:]
)
let flag = "targeting-42"
let context = OpenFeatureEvaluationContext(targetingKey: "swift")
await #expect(provider.resolution(of: flag, defaultValue: 0, context: context) == resolution)
}
}

@Test("No Targeting Match")
func noTargetingMatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: -42,
error: nil,
reason: .default,
variant: "a",
flagMetadata: [:]
)
let flag = "targeting-42"
await #expect(provider.resolution(of: flag, defaultValue: 0, context: nil) == resolution)
}
}

@Test("Type mismatch")
func typeMismatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: 42,
error: OpenFeatureResolutionError(
code: .typeMismatch,
message: #"Expected flag value of type "Int" but received "String"."#
),
reason: .error,
variant: "a"
)
let flag = "static-a"
await #expect(provider.resolution(of: flag, defaultValue: 42, context: nil) == resolution)
}
}
}

@Suite("Double Flag Resolution")
struct DoubleResolutionTests {
@Test("Static", arguments: [("static-negative-42.123", "a", -42.123), ("static-positive-42.123", "b", 42.123)])
func staticBool(flag: String, variant: String, expectedValue: Double) async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: expectedValue,
error: nil,
reason: .static,
variant: variant,
flagMetadata: [:]
)
await #expect(provider.resolution(of: flag, defaultValue: 0.0, context: nil) == resolution)
}
}

@Test("Targeting Match")
func targetingMatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: 42.123,
error: nil,
reason: .targetingMatch,
variant: "b",
flagMetadata: [:]
)
let flag = "targeting-42.123"
let context = OpenFeatureEvaluationContext(targetingKey: "swift")
await #expect(provider.resolution(of: flag, defaultValue: 0.0, context: context) == resolution)
}
}

@Test("No Targeting Match")
func noTargetingMatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: -42.123,
error: nil,
reason: .default,
variant: "a",
flagMetadata: [:]
)
let flag = "targeting-42.123"
await #expect(provider.resolution(of: flag, defaultValue: 0.0, context: nil) == resolution)
}
}

@Test("Type mismatch")
func typeMismatch() async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)

try await withOFREPProvider(provider) {
let resolution = OpenFeatureResolution(
value: 42.123,
error: OpenFeatureResolutionError(
code: .typeMismatch,
message: #"Expected flag value of type "Double" but received "String"."#
),
reason: .error,
variant: "a"
)
let flag = "static-a"
await #expect(provider.resolution(of: flag, defaultValue: 42.123, context: nil) == resolution)
}
}
}

@Test("Flag not found", arguments: [true, false])
func flagNotFound(defaultValue: Bool) async throws {
let provider = OFREPProvider(serverURL: URL(string: "http://localhost:8016")!)
Expand Down
109 changes: 106 additions & 3 deletions IntegrationTests/integration.flagd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,116 @@
]
}
},
"static-a-b": {
"static-a": {
"state": "ENABLED",
"variants": {
"a": "a",
"b": "b"
"a": "value-a",
"b": "value-b"
},
"defaultVariant": "a"
},
"static-b": {
"state": "ENABLED",
"variants": {
"a": "value-a",
"b": "value-b"
},
"defaultVariant": "b"
},
"targeting-b": {
"state": "ENABLED",
"variants": {
"a": "value-a",
"b": "value-b"
},
"defaultVariant": "a",
"targeting": {
"if": [
{
"===": [
{
"var": "targetingKey"
},
"swift"
]
},
"b"
]
}
},
"static-negative-42": {
"state": "ENABLED",
"variants": {
"a": -42,
"b": 42
},
"defaultVariant": "a"
},
"static-positive-42": {
"state": "ENABLED",
"variants": {
"a": -42,
"b": 42
},
"defaultVariant": "b"
},
"targeting-42": {
"state": "ENABLED",
"variants": {
"a": -42,
"b": 42
},
"defaultVariant": "a",
"targeting": {
"if": [
{
"===": [
{
"var": "targetingKey"
},
"swift"
]
},
"b"
]
}
},
"static-negative-42.123": {
"state": "ENABLED",
"variants": {
"a": -42.123,
"b": 42.123
},
"defaultVariant": "a"
},
"static-positive-42.123": {
"state": "ENABLED",
"variants": {
"a": -42.123,
"b": 42.123
},
"defaultVariant": "b"
},
"targeting-42.123": {
"state": "ENABLED",
"variants": {
"a": -42.123,
"b": 42.123
},
"defaultVariant": "a",
"targeting": {
"if": [
{
"===": [
{
"var": "targetingKey"
},
"swift"
]
},
"b"
]
}
}
}
}
Loading