Skip to content

Use welcoming language #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Use welcoming language #333

merged 1 commit into from
Jan 22, 2021

Conversation

fabianfett
Copy link
Member

To comply with the new Swift code of conduct, let's make the language a little more welcoming.

Modifications:

  • Replaced usages of "sanity" with "soundness"
  • Added "sanity" to the list of unacceptable terms.
  • Changed the CI name to soundness

Result:

  • Async HTTP Client is nicer.

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Jan 22, 2021
Lukasa
Lukasa approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, assuming the CI is functioning.

@tomerd
Copy link
Contributor

tomerd commented Jan 22, 2021

@swift-server-bot test this please

@tomerd
Copy link
Contributor

tomerd commented Jan 22, 2021 

Test Case 'HTTPClientTests.testSSLHandshakeErrorPropagation' started at 2021-01-22 17:22:24.646
/code/Tests/AsyncHTTPClientTests/HTTPClientTests.swift:2705: error: HTTPClientTests.testSSLHandshakeErrorPropagation : XCTAssertEqual failed: ("nil") is not equal to ("Optional(NIOSSL.NIOSSLError.uncleanShutdown)") -

flaky test?

@Lukasa
Copy link
Collaborator

Lukasa commented Jan 22, 2021

Yup

@Lukasa Lukasa mentioned this pull request Jan 22, 2021
Closed
@tomerd tomerd merged commit 9671de7 into swift-server:main Jan 22, 2021
@fabianfett fabianfett deleted the ff-welcoming-language branch January 22, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabianfett @tomerd @Lukasa @weissi