Prepare async/await API for public release #531
Conversation
| private let stream: IteratorStream | ||
|
|
||
| fileprivate init(stream: IteratorStream) { | ||
| self.stream = stream | ||
| } | ||
|
|
||
| func next() async throws -> ByteBuffer? { | ||
| public func next() async throws -> ByteBuffer? { |
There was a problem hiding this comment.
Question rather than suggestion: should this be mutating to indicate that next() consumes from the stream?
There was a problem hiding this comment.
Makes sense to me. @fabianfett any objections?
| @@ -12,9 +12,16 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| enum RequestBodyLength: Hashable { | |||
| public struct RequestBodyLength { | |||
There was a problem hiding this comment.
We should not add this type without prefix to the top namespace.
There was a problem hiding this comment.
Agreed. I have reverted the change and added a new public type HTTPClientRequest.Body.Length which is baked by RequestBodyLength and used as the public type instead.
dnadoba
force-pushed
the
dn-async-await-public
branch
2 times, most recently
from
509784b to
2702cb0
Compare
| extension HTTPClientRequest.Body { | ||
| public struct Length { | ||
| /// size of the request body is not known before starting the request | ||
| public static let dynamic: Self = .init(storage: .dynamic) |
There was a problem hiding this comment.
Is dynamic the right name here? What about unknown?
I like the storage workaround btw.
There was a problem hiding this comment.
btw. fixed is also weird. I guess known would be more appropriate. Also I think this type should be ExpressibleByIntegerLiteral.
|
@swift-server-bot test this please |
dnadoba
changed the title
and add nescary @inlinable/@usableFromInlinable for generic `HTTPClientReuqest.Body` builder metods.
dnadoba
force-pushed
the
dn-async-await-public
branch
from
f8bab65 to
10b8bd2
Compare
HTTPClientReuqest.Bodybuilder metods.HTTPClientReuqest.Body.byteBuffer(_:)toHTTPClientReuqest.Body.bytes(_:)to be more in line with the other overloadsHTTPClientReuqest.Body.Lengthinstead ofInt?to specify the length of a body if we can't infer the lengthlengthparameter to the end