-
Notifications
You must be signed in to change notification settings - Fork 32
Use only FoundationEssentials
when possible
#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
904af3d
use FoundationEssentials when possible
t089 5fab234
formatting
t089 1e9ef94
better naming
t089 d159792
adds tests and splits files
t089 f3e7c1f
Merge branch 'main' into foundation-essentials
t089 ef50f61
fix platform conditionals
t089 06e8dd3
reuse parse strategy
t089 561d37b
Merge branch 'main' into foundation-essentials
sebsto bc5d958
formatting
t089 072553a
missing header
t089 bf390f1
more robust platform checks
t089 91a4721
remove unneeded availability check
t089 e61e83b
remove another redundant check
t089 4a51be4
and another one
t089 25f4a4e
remove the last check
t089 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I don't think this will actually compile on older swift versions on Linux where this api is not yet available in Foundation, need to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there are a bunch of build errors with swift 5.10 on linux. will look into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next version will support Swift 6 and onwards, aligned on the Swift Lambda Runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you want to fix this or not. I'm happy to merge with a Swift 6 only change. If there is an easy fix, let's be nice with our existing users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the
if #available(macOS 12, *)
check was redundant as the conditional compile already excludes macOS altogether. Now it should compile for both on linux and macOS.