Skip to content

[core] Swift Service Lifecycle (WIP - do not merge) #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented Jan 5, 2025

Add support for Swift Service Lifecycle

This PR is just aimed at getting initial review, this is work in progress, I will add the docc + an example project before merging.

@sebsto sebsto added the semver/none No version bump required. label Jan 5, 2025
@sebsto sebsto changed the title [wip] Swift Service Lifecycle [core] Swift Service Lifecycle (WIP - do not merge) Jan 6, 2025
@sebsto
Copy link
Contributor Author

sebsto commented Jan 11, 2025

This implementation is not working yet.
We need to figure out how to cancel .nextInvocation() calls

let (invocation, writer) = try await runtimeClient.nextInvocation()

@sebsto sebsto added this to the 2.0 milestone Jan 16, 2025
@fabianfett
Copy link
Member

@sebsto we have landed this with traits, haven't we?

@sebsto
Copy link
Contributor Author

sebsto commented Mar 6, 2025

@fabianfett Not all of it.
In this PR, there is LambdaRuntimeService and an example
We need an extension to LambdaRuntime that implements Service protocol when the Trait in enabled.

I'm not sure it will be practical to merge this PR. I'll close it for now. And introduce the LambdaRuntime+Service and teh example in a separate PR

@sebsto sebsto closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants