-
Notifications
You must be signed in to change notification settings - Fork 113
Apply package traits #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply package traits #490
Conversation
Interesting change. Thank you. Quick question. What is the command to compile and disable a specific trait ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
"FoundationJSONSupport", | ||
"ServiceLifecycleSupport", | ||
"LocalServerSupport", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't know if this needs the support
suffix but not feeling too strongly
Cam we wait for 6.1 to be GA before merging this ? |
|
[email protected]
Outdated
// for testing only | ||
.library(name: "AWSLambdaTesting", targets: ["AWSLambdaTesting"]), | ||
], | ||
traits: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supported by the Swift 6.0 driver ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oversight. hupps.
) | ||
), | ||
.testTarget( | ||
name: "AWSLambdaRuntimeCoreTests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that AWSLambdaRuntimeCore doesn't exist, we should merge the tests too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this in a follow up to keep the changes as small as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let be sure we file an issue to track this otherwise it might stay like this forever :-)
b17f6c0
to
5ea6f25
Compare
@fabianfett can you merge with main |
5ea6f25
to
df50337
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll create issue to track follow up work
Play around with package traits