Add Windows build settings to find Windows SDK#279
Open
dschaefer2 wants to merge 1 commit into
Open
Conversation
Adds in the C settings to add the include path to the Windows SDK. Unsafe flags are no longer enforced enabling us to specify these absolute path names.
dschaefer2
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
Member
Author
|
@swift-ci please test windows |
compnerd
reviewed
Mar 6, 2026
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Can we do the look up for SDKROOT once?
Comment on lines
+137
to
+140
| .unsafeFlags([ | ||
| "-I" + (ProcessInfo.processInfo.environment["SDKROOT"] ?? "") + "\\usr\\include", | ||
| "-I" + (ProcessInfo.processInfo.environment["SDKROOT"] ?? "") + "\\usr\\include\\Block", | ||
| ], .when(platforms: [.windows])), |
Member
There was a problem hiding this comment.
I would say that we should just not add the flags if SDKROOT is unset.
Member
Author
There was a problem hiding this comment.
That's fair. It's a pretty ugly default. I'll rejig this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in the C settings to add the include path to the Windows SDK. Unsafe flags are no longer enforced starting in 6.2 enabling us to specify these absolute path names.