Add support for Emscripten platform separate from WASI#1335
Merged
Conversation
One of the necessary steps for implementing the Emscripten pitch: https://forums.swift.org/t/pitch-emscripten-target-support-for-swift/85310
MaxDesiatov
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
requested changes
Apr 22, 2026
Collaborator
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
Looks good, just a few spelling issues in the platform definition (those properties are all expected to differ only by case).
Contributor
Author
|
@swift-ci test |
jakepetroules
approved these changes
Apr 29, 2026
finagolfin
reviewed
Apr 29, 2026
| case android | ||
| case windows | ||
| case wasi | ||
| case emscripten |
Member
There was a problem hiding this comment.
This just broke building SwiftPM on CI:
14:09:47 /Users/ec2-user/jenkins/workspace/swift-package-manager-with-xcode-self-hosted-PR-osx-release-toolchain/branch-main/swiftpm/Sources/SwiftBuildSupport/PackagePIFProjectBuilder+Modules.swift:569:17: error: switch must be exhaustive
14:09:47 567 | for platform in ProjectModel.BuildSettings.Platform.allCases {
14:09:47 568 | // darwin & freebsd
14:09:47 569 | switch platform {
14:09:47 | |- error: switch must be exhaustive
14:09:47 | `- note: add missing case: '.emscripten'
14:09:47 570 | case .macOS, .macCatalyst, .iOS, .watchOS, .tvOS, .xrOS, .driverKit, .freebsd:
14:09:47 571 | impartedSettings[.OTHER_LDFLAGS, platform] = ["-lc++", "$(inherited)"]
Contributor
There was a problem hiding this comment.
swiftlang/swift-package-manager#10002 has been published to resolve the issue.
cmcgee1024
pushed a commit
that referenced
this pull request
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the necessary steps for implementing the Emscripten pitch: https://forums.swift.org/t/pitch-emscripten-target-support-for-swift/85310