Copy experimentalWindowsDLL artifact bundle variants to the target build directory#1384
Closed
daveinglis wants to merge 1 commit into
Closed
Copy experimentalWindowsDLL artifact bundle variants to the target build directory#1384daveinglis wants to merge 1 commit into
daveinglis wants to merge 1 commit into
Conversation
…ild directory Artifact bundles with `experimentalWindowsDLL` entries now have their matching variant copied to `$(TARGET_BUILD_DIR)` alongside the built product, using a workspace-level producer that guarantees deterministic, duplicate-free task generation regardless of how many targets transitively reference the same bundle. Architecture (mirrors XCFrameworkTaskProducer): - WindowsDLLCopyContext (new) — holds a [destinationPath: CopyRequirement] map on GlobalProductPlan. First registration per destination wins. - WindowsDLLCopyTaskProducer (new) — workspace-level producer registered alongside XCFrameworkTaskProducer in ProductPlanner. Its prepare() iterates target contexts *sequentially*, triple-matches DLL variants per arch, and registers (source, destination) pairs. Because iteration is sequential the winner is always the same target across incremental builds, eliminating the stale-file-removal warnings that a concurrent first-come-first-served approach would produce. generateTasks() emits one Copy task per registered destination. Tests: - artifactBundleWithWindowsDLLs: correct variant copied, non-matching skipped - artifactBundleWithWindowsDLLsNoMatchWarning: warning + no copy when no variant matches
daveinglis
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
doesn't look like we need this in 6.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Artifact bundles with
experimentalWindowsDLLentries now have their matching variant copied to$(TARGET_BUILD_DIR)alongside the built product, using a workspace-level producer that guarantees deterministic, duplicate-free task generation regardless of how many targets transitively reference the same bundle.Architecture (mirrors XCFrameworkTaskProducer):
WindowsDLLCopyContext (new) — holds a [destinationPath: CopyRequirement] map on GlobalProductPlan. First registration per destination wins.
WindowsDLLCopyTaskProducer (new) — workspace-level producer registered alongside XCFrameworkTaskProducer in ProductPlanner. Its prepare() iterates target contexts sequentially, triple-matches DLL variants per arch, and registers (source, destination) pairs. Because iteration is sequential the winner is always the same target across incremental builds, eliminating the stale-file-removal warnings that a concurrent first-come-first-served approach would produce. generateTasks() emits one Copy task per registered destination.
Tests: