Unregister app bundles from LaunchServices during clean#1385
Merged
rjmansfield merged 1 commit intoMay 22, 2026
Conversation
rjmansfield
requested review from
aciidgh,
jakepetroules,
mhrawdon,
neonichu and
owenv
as code owners
Contributor
Author
|
@swift-ci test |
jakepetroules
requested changes
May 11, 2026
| let paths = content.split(separator: "\n", omittingEmptySubsequences: true).map(String.init) | ||
| guard !paths.isEmpty else { return } | ||
|
|
||
| _Concurrency.Task.detached { |
Collaborator
There was a problem hiding this comment.
Let's please stick these in a task group instead of using detached tasks, we really want to maintain structured concurrency, and this as it is is subject to race conditions
owenv
reviewed
May 12, 2026
During builds, record app bundles registered with LaunchServices to a registered-launchservices.txt file. During clean, read the file and call lsregister -u to unregister them. rdar://142580463
rjmansfield
force-pushed
the
clean-unregister-launchservices
branch
from
694c872 to
1238345
Compare
owenv
approved these changes
May 21, 2026
jakepetroules
approved these changes
May 21, 2026
Contributor
Author
|
@swift-ci test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During builds, record app bundles registered with LaunchServices to a registered-launchservices.txt file. During clean, read the file and call lsregister -u to unregister them.
rdar://142580463