Add support for the libswiftCompatibilitySpan.dylib backward deployment library #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
This is a work-in-progress; I still want to add tests. Also the whole thing feels like a bunch of copy and paste. The problem is that "Swift in the OS" and "Swift concurrency" are two concepts plumbed through all these layers, and now I'm adding a third. Suggestions for improving this are welcome. |
slavapestov
force-pushed
the
compatibility-span
branch
from
32c3a6c to
414a184
Compare
| fileprivate(set) var minimumOSForSwiftConcurrency: Version? = nil | ||
|
|
||
| /// Minimum OS version for Span in the standard library (Swift 6.2). If this is `nil`, the platform does not support Swift concurrency at all. |
There was a problem hiding this comment.
"the platform does not support Swift concurrency at all."
Think this needs to be updated to reflect Span, rather than Swift Concurrency
| @@ -287,6 +295,29 @@ extension Platform { | |||
|
|
|||
| return version >= minimumSwiftConcurrencyVersion | |||
| } | |||
|
|
|||
| /// Determines if the platform natively supports Swift 6.2's Span type. If `false`, then the Swift Span back-compat concurrency libs needs to be copied into the app/framework's bundle. | |||
| public func supportsSwiftSpanNatively(_ scope: MacroEvaluationScope, forceNextMajorVersion: Bool = false, considerTargetDeviceOSVersion: Bool = true) -> Bool? { | |||
There was a problem hiding this comment.
Why add default values for the arguments? This is only ever called in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.