Check for the index workspace description rather than index arena #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci please test |
neonichu
approved these changes
Apr 23, 2025
bnbarham
commented
Apr 23, 2025
Tests/SWBBuildSystemTests/HostBuildToolBuildOperationTests.swift
Outdated
Show resolved
Hide resolved
bnbarham
force-pushed
the
skip-param-replacement-for-package
branch
from
f18351b to
58a11b9
Compare
|
@swift-ci please test |
jakepetroules
approved these changes
Apr 24, 2025
bnbarham
force-pushed
the
skip-param-replacement-for-package
branch
from
58a11b9 to
ec3aa56
Compare
|
@swift-ci please test |
There's various paths that should be specific to the index workspace description rather than if the index arena is enabled. Specifically the recent change to replace parameters for host tools (swiftlang#345) broke the *package* description as it uses the passed in run destination rather than configuring for all platforms. This replacement would then create two configured targets for macOS for the same target (one for the given run destination and one for the macOS platform that the index uses). This also changes the *target* description to only build for the run destination, which makes sense given its entire purpose is to be a replacement for the workspace description if it hasn't built yet (ie. it should be as fast as possible). Resolves rdar://149896775.
bnbarham
force-pushed
the
skip-param-replacement-for-package
branch
from
ec3aa56 to
1ca14af
Compare
|
@swift-ci please test |
|
(just a bunch more test updates for tests using SDKs I didn't have locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's various paths that should be specific to the index workspace description rather than if the index arena is enabled. Specifically the recent change to replace parameters for host tools (#345) broke the package description as it uses the passed in run destination rather than configuring for all platforms. This replacement would then create two configured targets for macOS for the same target (one for the given run destination and one for the macOS platform that the index uses).
This also changes the target description to only build for the run destination, which makes sense given its entire purpose is to be a replacement for the workspace description if it hasn't built yet (ie. it should be as fast as possible).
Resolves rdar://149896775.