Skip to content

[CI] Add support for GitHub Actions#446

Merged
shahmishal merged 14 commits into
mainfrom
github-actions-support
Apr 29, 2025
Merged

[CI] Add support for GitHub Actions#446
shahmishal merged 14 commits into
mainfrom
github-actions-support

Conversation

@shahmishal
Copy link
Copy Markdown
Member

No description provided.

Comment thread .github/workflows/pull_request.yml
Comment thread .github/workflows/pull_request.yml Outdated
Comment thread .github/workflows/pull_request.yml Outdated
Comment thread .github/workflows/pull_request.yml Outdated
@shahmishal shahmishal marked this pull request as draft April 27, 2025 23:25
@owenv
Copy link
Copy Markdown
Collaborator

owenv commented Apr 28, 2025

We should probably turn off api_breakage_check_enabled as well since we don't expose a long-term stable API

@owenv
Copy link
Copy Markdown
Collaborator

owenv commented Apr 28, 2025

6.0 jobs fix: #447

@owenv
Copy link
Copy Markdown
Collaborator

owenv commented Apr 28, 2025

shellcheck fix: #448

Comment thread .licenseignore Outdated
Comment thread .github/workflows/pull_request.yml Outdated
linux_pre_build_command: apt-get update && apt-get install -y libsqlite3-dev libncurses5-dev
windows_exclude_swift_versions: '[{"swift_version": "5.9"}, {"swift_version": "5.10"}]'
linux_os_versions: '["noble", "jammy", "focal", "rhel-ubi9"]'
linux_pre_build_command: command -v apt >/dev/null 2>&1 && apt update && apt install -y libsqlite3-dev libncurses5-dev || (command -v yum >/dev/null 2>&1 && yum update -y && yum install -y sqlite-devel)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On RedHat it's libncurses-dev; I'd add that too.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No match for argument: libncurses-dev
Error: Unable to find a match: libncurses-dev

Going to revert back to not including it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, checked again and it's ncurses-devel.

I was looking at the Debian metapackage before -- and on Debian we should use libncurses-dev rather than libncurses5-dev; the latter is a transitional package for libncurses-dev.

@jakepetroules
Copy link
Copy Markdown
Collaborator

Try adding --no-parallel to swift test so we can narrow down which test is crashing?

Copy link
Copy Markdown
Collaborator

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to land build-only as a first round?

@shahmishal
Copy link
Copy Markdown
Member Author

@swift-ci test

@shahmishal shahmishal marked this pull request as ready for review April 29, 2025 08:16
@shahmishal shahmishal enabled auto-merge (squash) April 29, 2025 08:16
@shahmishal shahmishal merged commit e97614b into main Apr 29, 2025
22 checks passed
@shahmishal shahmishal deleted the github-actions-support branch April 29, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants