WIP: Prototype for a TemporaryDirectoryTrait and AsyncDeferrableTrait#763
Draft
ahoppen wants to merge 2 commits into
Draft
WIP: Prototype for a TemporaryDirectoryTrait and AsyncDeferrableTrait#763ahoppen wants to merge 2 commits into
TemporaryDirectoryTrait and AsyncDeferrableTrait#763ahoppen wants to merge 2 commits into
Conversation
This can be useful when implementing a system that needs to configure the active run destination of a build request but only knows the platform that the user is requesting a build for, but no architecture etc.
…ait` I just want to raise the idea of using test traits over `with` function to avoid nesting levels due to `with*` functions in tests.
Collaborator
|
I kind of like this, but at the same time it would be a lot of effort to go change it all.. |
Contributor
I volunteer as tribute if it means we could switch to this. Could also just do it one test file at a time or something similar 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #760.
I just want to raise the idea of using test traits over
withfunction to avoid nesting levels due towith*functions in tests.