Cherry Pick Conditional Bridge Behavior for Swift 4.2 Branch #1797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original change for this did not check the behavior. A better implementation here is to use the one from Swift itself, which also matches the initializer that this extension also adds.
|
Paging @millenomi and @parkera, who suggested this should also get pulled to the 4.2 branch. |
|
I'm going to merge this so it's staged for a potential release. |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #1703 for the original details around the fix.
Work for 4.2 originally regressed this behavior from 4.1 and earlier, so this really should be fixed in 4.2 for Linux as well as the original commit to master.