Use availability item platform name to compute default availability information. #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nformation. This change makes a small tweak to the default availability logic so it uses the symbol availability item platform name instead of the symbol graph platform name to calculate the corresponding default introduced version from the default availability. rdar://146774862
anferbui
approved these changes
May 1, 2025
Contributor
anferbui
left a comment
anferbui
left a comment
There was a problem hiding this comment.
LGTM, thank you for looking into this 🎉
Contributor
Author
|
@swift-ci please test |
sofiaromorales
added a commit
to sofiaromorales/swift-docc
that referenced
this pull request
May 2, 2025
…nformation. (swiftlang#1208) Use availability item platform name to compute default availability information. This change makes a small tweak to the default availability logic so it uses the symbol availability item platform name instead of the symbol graph platform name to calculate the corresponding default introduced version from the default availability. rdar://146774862
sofiaromorales
added a commit
that referenced
this pull request
May 2, 2025
…nformation. (#1208) (#1211) Use availability item platform name to compute default availability information. This change makes a small tweak to the default availability logic so it uses the symbol availability item platform name instead of the symbol graph platform name to calculate the corresponding default introduced version from the default availability. rdar://146774862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: rdar://146774862
Summary
This PR makes a small tweak to the default availability logic so it uses the symbol availability item platform name instead of the symbol graph platform name to calculate the corresponding default introduced version from the default availability.
Dependencies
N/A
Testing
Availability.docc.zip
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded