-
Notifications
You must be signed in to change notification settings - Fork 194
Dockerfile for Debian 10/buster #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
FROM debian:10 | ||
|
||
RUN groupadd -g 998 build-user && \ | ||
useradd -m -r -u 998 -g build-user build-user | ||
|
||
ENV DEBIAN_FRONTEND="noninteractive" | ||
|
||
RUN apt-get update | ||
|
||
RUN apt-get -y --no-install-recommends install \ | ||
build-essential \ | ||
clang \ | ||
cmake \ | ||
git \ | ||
icu-devtools \ | ||
libcurl4-openssl-dev \ | ||
libedit-dev \ | ||
libicu-dev \ | ||
libncurses5-dev \ | ||
libsqlite3-dev \ | ||
libxml2-dev \ | ||
ninja-build \ | ||
python \ | ||
python-dev \ | ||
python-six \ | ||
pkg-config \ | ||
rsync \ | ||
swig \ | ||
systemtap-sdt-dev \ | ||
tzdata \ | ||
unzip \ | ||
vim \ | ||
uuid-dev \ | ||
ca-certificates | ||
|
||
USER build-user | ||
|
||
WORKDIR /home/build-user |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,9 +5,9 @@ RUN groupadd -g 998 build-user && \ | |
|
||
ENV DEBIAN_FRONTEND="noninteractive" | ||
|
||
RUN apt update | ||
RUN apt-get update | ||
|
||
RUN apt -y install \ | ||
RUN apt-get -y --no-install-recommends install \ | ||
build-essential \ | ||
clang \ | ||
cmake \ | ||
|
@@ -30,7 +30,8 @@ RUN apt -y install \ | |
tzdata \ | ||
unzip \ | ||
vim \ | ||
uuid-dev | ||
uuid-dev \ | ||
ca-certificates | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. worth noting that the Debian 9 dockerfile is still one we are working on, hence we did not publish toolchain for debian yet. |
||
|
||
USER build-user | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @schafdog this is awesome. did you review all the above to make sure it the minimal set. for example I am a tad surprised to see
vim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not at all optimized to be minimal. There was already a debian 9 dockerfile that I based 10 upon. Doing a manual build in the container I saw that just doing git clone failed due to missing CA certificates, which I added. I believe it did build after that.
Still a bit insecure on how to "prove" that the dockerfile / image would work 100% to build the full toolchain and run the tests. Kind of interested in taking it all the way to debian packages, but can't say I have much experience in this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding guide for local testing in #171