Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply swiftlang#442 to the Dockerfile that runs in CI #444

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Apply swiftlang#442 to the Dockerfile that runs in CI #444

merged 1 commit into from
Mar 4, 2025

Conversation

weliveindetail
Copy link
Member

  • Use HTTPS for the latest download info.
  • Immediately convert from JSON to help make failures more understandable.
  • Perform the JSON conversion once to avoid repeated parsing.

@weliveindetail
Copy link
Member Author

@compnerd @shahmishal These changes seem reasonable in general, so why not apply them here as well?

@weliveindetail
Copy link
Member Author

@swift-ci please test

@weliveindetail
Copy link
Member Author

FYI Swift Test Dockerfiles failed in "ci_test.py", line 78 the same way as the other PR. I assume this can land, but I have no merge permission.

@weliveindetail weliveindetail changed the title Apply #442 to the Dockerfile that runs in CI Apply swiftlang#442 to the Dockerfile that runs in CI Feb 26, 2025
@weliveindetail
Copy link
Member Author

@compnerd CI in https://ci-external.swift.org/view/xInfrastructure/job/publish-nightly-main-docker-images/ is back to green, so I guess this can land now

@shahmishal shahmishal merged commit e254ad9 into swiftlang:main Mar 4, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal shahmishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weliveindetail @shahmishal