Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a proposal to change the execution semantics of nonisolated async functions. #2572

Merged
merged 13 commits into from
Feb 20, 2025
Merged

Add a proposal to change the execution semantics of nonisolated async functions. #2572

merged 13 commits into from
Feb 20, 2025

Conversation

hborla
Copy link
Member

@hborla hborla commented Sep 22, 2024

No description provided.

@hborla hborla force-pushed the async-function-isolation branch from aa7ca5a to 5c48918 Compare September 22, 2024 23:33
@rjmccall rjmccall added the LSG Contains topics under the domain of the Language Steering Group label Sep 30, 2024
@hborla hborla force-pushed the async-function-isolation branch from 70cd2d8 to 65b1096 Compare November 22, 2024 20:58
@hborla hborla force-pushed the async-function-isolation branch 2 times, most recently from 3029a07 to 25d3a7d Compare February 17, 2025 00:53
@hborla hborla force-pushed the async-function-isolation branch from 25d3a7d to 2480b83 Compare February 17, 2025 00:59
@hborla hborla marked this pull request as ready for review February 17, 2025 00:59
@hborla
Copy link
Member Author

hborla commented Feb 17, 2025

@xwu (cc @DougGregor) as review manager: I revised the proposal based on feedback from the pitch and vision document discussion in 2480b83. I made a ton of editorial changes, but the substantive revisions that I made are explicitly listed in the new Revisions section:

Revisions

The proposal was revised with the following changes after the pitch discussion:

  • Gate the behavior change behind an AsyncCallerExecution upcoming feature
    flag.
  • Change the spelling of @concurrent to @execution(concurrent), and add an
    @execution(caller) attribute to allow expressing the new behavior this
    proposal introduces when the upcoming feature flag is not enabled.
  • Apply @execution(caller) to nonisolated async function types by default to
    make the execution semantics consistent between async function declarations
    and values.
  • Change the terminology in the proposal to not use the "inherits isolation"
    phrase.

There is also now an implementation of this proposal on main under an experimental feature.

@hborla
Address feedback from the Language Steering Group.
0b09179 
1. Make it clear that in the end, `@execution(caller)` will rarely
   be explicit in source.
2. Simplify the function conversions section using a table, and
   clarify the rules for non-`@Sendable` function conversions.
3. Address alternative spellings for `@execution` in the alternatives
   considered section.
@hborla
Remove a confusing line of reasoning. It's not very compelling
732a7fe 
anyway.
@hborla
Editorial changes to the proposed solution.
6cc3293
@hborla
Clarify that the import-as-async change is not gated behind the
3b0a69d 
upcoming feature.
@hborla
Copy link
Member Author

hborla commented Feb 20, 2025

@xwu I could continue with editorial passes on this proposal all day, but I think I've addressed the feedback from the LSG

@xwu xwu merged commit c1fc2b9 into swiftlang:main Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmassicotte mattmassicotte mattmassicotte left review comments

@jamieQ jamieQ jamieQ left review comments

Assignees
No one assigned
Labels
LSG Contains topics under the domain of the Language Steering Group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hborla @mattmassicotte @jamieQ @xwu @rjmccall