Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Task Naming API #2619

Merged
merged 10 commits into from
Mar 13, 2025
Merged

Conversation

Harjas12
Copy link
Contributor

No description provided.

@Harjas12 Harjas12 force-pushed the task-naming-api-proposal branch 2 times, most recently from 7f71aac to c0e0748 Compare November 19, 2024 03:04

```swift
init(
name: String? = nil,
Copy link
Contributor

@ktoso ktoso Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- no change after all here --

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I may ask: is something you both would consider for the naming API to use an enum? I am asking this, because it would be also good to in case of having to iterate over the Tasks we may have, comparing them or even making using a switch. Of course, my suggestion is not to remove the String as a type for naming it, but having a second flexible way to deal with them.

What do you think?

Copy link
Contributor

@ktoso ktoso Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal "content" discussions let's do in the review thread on the Swift forums

@ktoso
Copy link
Contributor

ktoso commented Nov 19, 2024

@Harjas12 I did some updates, please check and merge them :)

@Harjas12 Harjas12 force-pushed the task-naming-api-proposal branch from d1443e9 to 205a51e Compare November 19, 2024 23:06
@rjmccall rjmccall added the LSG Contains topics under the domain of the Language Steering Group label Dec 9, 2024
@ktoso
Copy link
Contributor

ktoso commented Mar 10, 2025

This is now implemented and we could kick off a review -- swiftlang/swift#79600

The proposal is up to date. cc @swiftlang/language-steering-group

@hborla hborla self-assigned this Mar 13, 2025
@hborla hborla merged commit ceabe46 into swiftlang:main Mar 13, 2025
@ktoso ktoso deleted the task-naming-api-proposal branch March 14, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSG Contains topics under the domain of the Language Steering Group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants