Task Priority Escalation APIs #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Feb 6, 2025
Co-authored-by: Franz Busch <[email protected]>
FranzBusch
reviewed
Feb 7, 2025
pyrtsa
reviewed
Feb 8, 2025
ktoso
force-pushed
the
wip-task-prio-escalation
branch
from
cea9422 to
9b37040
Compare
ktoso
force-pushed
the
wip-task-prio-escalation
branch
from
9b37040 to
f0f83ec
Compare
jamieQ
reviewed
Feb 12, 2025
| } | ||
| ``` | ||
|
|
||
| The above example showcases a common pattern: often an unchecked continuation is paired with a Task used to complete it. Around the suspension on the continuation, waiting for it to be resumed, developers often install a task cancellation handler in order to potentially break out of potentially unbounded waiting for a continuation to be resumed. Around the same suspension (marked with `HERE` in the snippet above), we might want to insert a task priority escalation handler in order to priority boost the task that is used to resume the continuation. This can be important for correctness and performance of such operations, so we should find a way to offer these libraries to participate in task priority handling. |
There was a problem hiding this comment.
nit:
often an unchecked continuation
there's a mix of checked & unchecked continuations in the above example. maybe drop the additional descriptor and just go with 'continuation'.
so we should find a way to offer these libraries [a mechanism] to participate in task priority handling.
ktoso
commented
Feb 12, 2025
Co-authored-by: Jamie <[email protected]>
|
This should be ready to go 👍 |
Jumhyn
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for impl over at: swiftlang/swift#78625