build: adopt current best practices for installation#1212
Open
compnerd wants to merge 2 commits intoswiftlang:mainfrom
Open
build: adopt current best practices for installation#1212compnerd wants to merge 2 commits intoswiftlang:mainfrom
compnerd wants to merge 2 commits intoswiftlang:mainfrom
Conversation
Member
Author
|
@swift-ci please test |
Member
Author
|
This is replicating what has been done with swift-testing, swift-corelibs-xctest, and is in the process of being applied to swift-corelibs-libdispatch as well. |
Add the `*_INSTALL_NESTED_SUBDIR` option and use `-print-target-info` to compute the install locations. This reduces the number of times we need to invoke the compiler and compute these values.
Member
Author
|
@swift-ci please test |
jmschonfeld
reviewed
Mar 17, 2025
Co-authored-by: Jeremy Schonfeld <jeremyschonfeld@gmail.com>
Contributor
|
The change itself looks ok to me now - thanks for the explanations, but since this repo can't test CMake changes can you build a Linux + Windows toolchain via a cross-repo PR so that we can compare the toolchains and make sure that things still build and that they end up in the right places? |
Contributor
|
@swift-ci please test |
Member
Author
|
Seems that the Linux toolchain build did uncover something. Will take a look once I clear up some more of the Windows patches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
*_INSTALL_NESTED_SUBDIRoption and use-print-target-infoto compute the install locations. This reduces the number of times we need to invoke the compiler and compute these values.