Move off of RegexBuilder for URL.Template #1273
Open
+11
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
itingliu
reviewed
Apr 25, 2025
| } | ||
| } | ||
| } | ||
| self.operatorRegex = try! Regex(#"([\+#.\/;\?&])?"#) |
There was a problem hiding this comment.
Do you know if it makes a difference whether you create a Regex this way or the other one that specifies the output type?
init(
_ pattern: String,
as outputType: Output.Type = Output.self
) throwsFor example would it help the performance since we can bypass parsing the result from AnyOutputRegex?
There was a problem hiding this comment.
I have no idea if that makes any difference. Happy to change it, if that helps. These are only every created once, though.
itingliu
approved these changes
Apr 25, 2025
|
@danieleggert Can you rebase to resolve the merge conflict? |
jrflat
approved these changes
May 12, 2025
| @@ -176,6 +177,7 @@ extension URL.Template: CustomStringConvertible { | |||
| } | |||
| } | |||
|
|
|||
| @available(FoundationPreview 6.2, *) | |||
There was a problem hiding this comment.
I don't think this annotation is needed since URL.Template.Element is an internal type, but otherwise LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1269
This uses
try! Regex("…")instead ofRegexBuilderto create regular expressions used by the URL Template implementation.