Skip to content

[6.4] SwiftBuild: expose STRIP_INSTALLED_PRODUCT setting#10038

Merged
bkhouri merged 1 commit into
swiftlang:release/6.4.xfrom
bkhouri:t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product
May 15, 2026
Merged

[6.4] SwiftBuild: expose STRIP_INSTALLED_PRODUCT setting#10038
bkhouri merged 1 commit into
swiftlang:release/6.4.xfrom
bkhouri:t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product

Conversation

@bkhouri
Copy link
Copy Markdown
Contributor

@bkhouri bkhouri commented May 8, 2026

Allow the STRIP_INSTALLED_PRODUCT build setting in the Swift Build settings to be configuration in SwiftPM.

Add an "enable/disable" build options that will sets the settings value accordingly. When not set, the products are not stripped, matching the native build system.

Fixes: #10037
Issue: rdar://176554583

Depends on: swiftlang/swift-build#1395

@bkhouri bkhouri force-pushed the t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product branch from d161a1d to 130d98e Compare May 8, 2026 17:20
@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 8, 2026

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product branch from 130d98e to c0f8186 Compare May 10, 2026 22:47
@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 10, 2026

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product branch from c0f8186 to 660d3eb Compare May 11, 2026 16:15
@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 11, 2026

@swift-ci test

@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 11, 2026

@swift-ci test windows

Comment thread Sources/CoreCommands/Options.swift Outdated
@bkhouri bkhouri force-pushed the t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product branch from 660d3eb to 4f8cd5f Compare May 12, 2026 03:06
@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 12, 2026

@swift-ci test

@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 12, 2026

@swift-ci test windows

1 similar comment
@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 12, 2026

@swift-ci test windows

bkhouri added a commit to bkhouri/swift-build that referenced this pull request May 13, 2026
A feature is being added to swift package manager in swiftlang/swift-package-manager#10038 to not strip binaries in release mode.  However, some package product object libraries on some platforms.

This change excludes stripping object libraries.

Relates to swiftlang/swift-package-manager#10037
Allow the STRIP_INSTALLED_PRODUCT build setting in the Swift Build
settings to be configuration in SwiftPM.

Add an "enable/disable" build options that will sets the settings value
accordingly.  When not set, the products are not stripped, matching the
native build system.

Fixes: swiftlang#10037
Issue: rdar://176554583
@bkhouri bkhouri force-pushed the t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product branch from 4f8cd5f to 2e64eae Compare May 14, 2026 17:39
@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 14, 2026

@swift-ci test

@bkhouri
Copy link
Copy Markdown
Contributor Author

bkhouri commented May 14, 2026

@swift-ci test windows

@bkhouri bkhouri enabled auto-merge (squash) May 14, 2026 22:45
@bkhouri bkhouri disabled auto-merge May 14, 2026 22:47
@bkhouri bkhouri enabled auto-merge (squash) May 14, 2026 22:48
@bkhouri bkhouri merged commit 1d29fcd into swiftlang:release/6.4.x May 15, 2026
47 checks passed
@bkhouri bkhouri deleted the t/main/gh10037_rdar176554583_add_configurable_setting_for_strip_installed_product branch May 15, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants