Add support for symbol graph generation for clang targets#10057
Open
cmcgee1024 wants to merge 3 commits into
Open
Add support for symbol graph generation for clang targets#10057cmcgee1024 wants to merge 3 commits into
cmcgee1024 wants to merge 3 commits into
Conversation
Member
Author
|
@swift-ci please test |
cmcgee1024
requested review from
bkhouri,
bripeticca,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
owenv
reviewed
May 15, 2026
Contributor
owenv
left a comment
owenv
left a comment
There was a problem hiding this comment.
This lgtm but I think we should have a test which generates the symbol graph end to end
| #expect(sources == expected) | ||
| } | ||
|
|
||
| @Test func symbolGraphExtractorBuildSettings() async throws { |
Contributor
There was a problem hiding this comment.
I think it would also be valuable to have a test for this which runs a build end to end and verifies we can correctly extract the symbol graph
Member
Author
There was a problem hiding this comment.
I'm hoping to avoid yet another e2e test in SwiftPM. There are other e2e tests for symbol graphs in general. If it's important then I'll add it.
| // for symbol graph generation. For non-swift API that will be done using TAPI and | ||
| // a build setting to instruct it to use project visible header files. In the future | ||
| // it may be possible to add public header files with public header visibility. | ||
| for headerPath in headerFiles { |
Contributor
There was a problem hiding this comment.
One thing we should double check is that this doesn't cause us to generate any headermaps we didn't before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for symbol graph generation for clang targets: