Fixup tests which mixed Swift Testing and XCTest asserts#10058
Open
owenv wants to merge 1 commit into
Open
Conversation
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand and
rconnell9
as code owners
Contributor
Author
|
@swift-ci test |
bkhouri
reviewed
May 13, 2026
|
|
||
| testDiagnostics(observability.diagnostics) { result in | ||
| result.check( | ||
| diagnostic: .contains("unable to delete"), |
Contributor
There was a problem hiding this comment.
issue: this test used an FileSystemDouble which throws an exception when trying to remove a file or a tree. so I would expect this diagnostic to get emitted.
Contributor
Author
There was a problem hiding this comment.
I didn't see this warning locally, but maybe that's unique to my CI setup. I'll see what the CI jobs report and change this if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran across a couple of tests which indirectly mixed test frameworks indirectly via the
checkhelper, update its implementation to avoid this.