[6.4] Address feedback#10070
Open
bkhouri wants to merge 2 commits into
Open
Conversation
TSwift Build does not suport testTarget that depend on another testTarget, and the error produced was not clear. This change modifies the PIF Builder to emit an error diagnostics when it detects a testTarget depends on another testTarget. Fixes: swiftlang#10062 Issue: rdar://174431298
In swiftlang#10064, a diagnostic error was introduced during PIF generation when a test target has a dependency on another test target. There were non-blocking feedback in the PR which are being addressed here. Relates to swiftlang#10062 Issue: rdar://174431298 Depends on swiftlang#10064
Contributor
Author
|
@swift-ci test |
bkhouri
requested review from
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
jakepetroules
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10064, a diagnostic error was introduced during PIF generation when a test target has a dependency on another test target. There were non-blocking feedback in the PR which are being addressed here.
Relates to #10062
Issue: rdar://174431298
Depends on #10064