swift-package-migrate: Report a fix-it application summary #8684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
AnthonyLatsis
force-pushed
the
dia-especial-2
branch
3 times, most recently
from
4076bec to
a49c475
Compare
dschaefer2
approved these changes
May 23, 2025
xedin
approved these changes
May 23, 2025
Other commands don't do this. Be consistent.
`SwiftIDEUtils.FixItApplier.applyFixes` performs some O(n^2) filtering based on `SwiftDiagnostics.FixItMessage` messages, which we don't need. Use the overload that directly takes an array of source edits instead.
AnthonyLatsis
force-pushed
the
dia-especial-2
branch
from
a49c475 to
0f97b3e
Compare
|
@swift-ci please test |
|
@swift-ci please test self hosted Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
> Applied 3 fix-its in 1 file (0.001s).Don’t output messages with a period for consistency with other commands.
Minor optimization for fix-it application.
SwiftIDEUtils.FixItApplier.applyFixesperforms some O(n^2) filtering based onSwiftDiagnostics.FixItMessagemessages, which we don't need. Use the overload that directly takes an array of source edits instead.Sits on top of #8683.