Add FreeBSD platform again to SwiftBuild PIF builder #8686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmattos
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
plemarquand
approved these changes
May 16, 2025
|
@swift-ci please test |
pmattos
commented
May 17, 2025
| @@ -968,6 +968,7 @@ extension ProjectModel.BuildSettings.Platform { | |||
| case .windows: .windows | |||
| case .wasi: .wasi | |||
| case .openbsd: .openbsd | |||
| case .freebsd: .freebsd | |||
| default: preconditionFailure("Unexpected platform: \(platform.name)") | |||
There was a problem hiding this comment.
FYI, I discussed this offline with @jakepetroules and will add proper error handling here.
No more hard preconditionFailures, as this could cause clients to crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix a silly typo I did in #8539 (i.e.,
Sources/SwiftBuildSupport/PackagePIFBuilder+Helpers.swift), where I removed thefreebsdplatform by mistake 🫠Modifications:
Add back
freebsdto theSwiftBuild.ProjectModel.BuildSettings.Platformvalue we sent over to Swift Build.Tracked by rdar://151042619.