6.2: Use WasmKit by default for Wasm triples in toolsets #8692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As [WasmKit](https://github.com/swiftwasm/WasmKit) is included in recent development snapshots of the swift.org toolchain, we should select it as a default debugger and test runner when a Wasm triple is selected. User toolsets can still override it if needed through toolset merging algorithm described in [SE-0387](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md). This allows `swift run` and `swift test` to delegate to WasmKit when cross-compiling for any Wasm triple. rdar://150382758 # Conflicts: # Tests/PackageModelTests/SwiftSDKBundleTests.swift
|
@swift-ci test |
MaxDesiatov
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
swiftlang/sourcekit-lsp#2162 |
1 similar comment
|
swiftlang/sourcekit-lsp#2162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #8668, merged as 02fe923
Explanation: As WasmKit is included in recent development snapshots of the swift.org toolchain, we should select it as a default debugger and test runner when a Wasm triple is selected. User toolsets can still override it if needed through toolset merging algorithm described in SE-0387.
This allows
swift runandswift testto delegate to WasmKit when cross-compiling for any Wasm triple.Scope: Limited to cross-compilation.
Risk: Low due to limited scope and added test coverage.
Testing: Add new automated test cases, manual testing with Wasm products.
Issue: rdar://150382758
Reviewer: @kateinoigakukun @jakepetroules