Skip to content

Promote to public operation to compute PIF GUID for products #9409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Promote to public operation to compute PIF GUID for products #9409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SwiftBuildSupport/PackagePIFBuilder+Helpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ import enum SwiftBuild.ProjectModel

// MARK: - PIF GUID Helpers

enum TargetSuffix: String {
public enum TargetSuffix: String {
case testable, dynamic

func hasSuffix(id: GUID) -> Bool {
Expand Down Expand Up @@ -136,7 +136,7 @@ extension PackagePIFBuilder {
///
/// This format helps make sure that there is no collision with any other PIF targets,
/// and in particular that a PIF target and a PIF product can have the same name (as they often do).
static func targetGUID(forProductName name: String, withId id: String, suffix: TargetSuffix? = nil) -> GUID {
public static func targetGUID(forProductName name: String, withId id: String, suffix: TargetSuffix? = nil) -> GUID {
let suffixDescription: String = suffix.uniqueDescription(forName: name)
return "PACKAGE-PRODUCT:\(id).\(name)\(suffixDescription)"
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/SwiftBuildSupport/PackagePIFBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import struct PackageGraph.ResolvedPackage

import enum SwiftBuild.ProjectModel

typealias GUID = SwiftBuild.ProjectModel.GUID
public typealias GUID = SwiftBuild.ProjectModel.GUID
typealias BuildFile = SwiftBuild.ProjectModel.BuildFile
typealias BuildConfig = SwiftBuild.ProjectModel.BuildConfig
typealias BuildSettings = SwiftBuild.ProjectModel.BuildSettings
Expand Down