Prebuilts for all host targets#9905
Open
dschaefer2 wants to merge 16 commits into
Open
Conversation
I had attempted in 6.3 to support using swift-syntax prebuilts for all host target builds. This would allow packages that have code generators invoked from plugins to take advantage of the build performance gain as well. SwiftBuild didn't have full support for cross building from all host platforms so I had to back that out. But for 6.4 it seems to be ready. This brings back the previous attempt but only for the Native build system currently. I'll need more work in SwiftBuild itself to ensure I have the full power of platform filters for the target dependencies and build settings for host to make this work. For now this is just a WIP. Once I have the SwiftBuild piece, I'll add it here and we can push it forward.
dschaefer2
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveinglis,
daveyc123,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
dschaefer2
changed the title
dschaefer2
changed the title
dschaefer2
changed the title
Member
Author
|
@swift-ci please test |
dschaefer2
commented
May 13, 2026
| unsafeAllowedPackages: Set<PackageReference> = [], | ||
| binaryArtifacts: [PackageIdentity: [String: BinaryArtifact]], | ||
| prebuilts: [PackageIdentity: [String: PrebuiltLibrary]], // Product name to library mapping | ||
| prebuilts: [PackageIdentity: [PrebuiltLibrary]], // Product name to library mapping |
Member
Author
There was a problem hiding this comment.
That comment should be fixed for the change. I'll fix if we need a respin. This isn't worth losing another day over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for prebuilts for all targets that build for host. Remove the previous attempt that used platform constraints on the modules.
Creates a new BinaryModule kind for Prebuilts so they can be explicit in the module graph instead of adding flags to all dependents of the prebuilts. We also remove those
PREBUILT_flags since they are no longer needed.A hook is added to the PlatformsCondition to model whether it is satisfied by a platform that supports the prebuilts. Dependents of the prebuilts module mark the dependency as true (i.e. for host) while leaving the dependencies on the source modules as false (i.e. for non-host). This allows the module to depend on both and the build system to decide which one to use to match the prebuilts platform.
For native, this translates into the host destination builds, i.e. host tools, using the prebuilts and the target destination (even if it's the same as the host) to use the corresponding modules from source.
For SwiftBuild, this uses a new extension to the PlatformFilter to exclude the named platform/environment. The prebuilt dependencies have a platform filter of host and the corresponding source module to exclude the host.
Also cleaned up how the prebuilts are passed into the resolution code. The product name to library isn't really required since there is only one prebuilt library for the foreseeable future.