Code actions to convert between computed properties and zero-parameter functions

[antigluten]

A part of swiftlang/sourcekit-lsp#1246

[harlanhaskins]

This is awesome!

Can you also add some tests to make sure this doesn't suggest the refactor:

var x: Int {
    get { 5 }
    set { /*anything */ }
}

And that the refactor succeeds with:

var x: Int {
    get { 5 }
}

[ahoppen]

Very nice. The test suggestion from @harlanhaskins would be good to address as well but I’m pretty sure those test will pass.

[antigluten]

@harlanhaskins Thank you, for your test suggestion!
@ahoppen, Thanks for your review, refactoring is done, added checking for get accessor when we converting to the function

[ahoppen]

Thanks for also adding support for a variable with an explicit get getter.

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[ahoppen]

Instead of merging main into your branch, could you rebase your branch on top of the latest main? It makes for a nicer git history and it’s too easy to hide weird subtle changes in merge commits.

[antigluten]

@ahoppen, thank you for your hint, done rebasing

[antigluten]

Accidentally removed the wrong branch

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows