Merged
Conversation
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
bnbarham
approved these changes
Mar 7, 2025
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
I quite dislike the #ifs for the imports, but I don't have a better suggestion.
Mostly, ensure that we only use `@_implementationOnly` if we build with `RESILIENT_LIBRARIES`. Also, `strerror` is marked as unsafe and deprecated on Windows. It looks like this is because `strerror` is not thread-safe. Switch to the thread-safe version `strerror_r` instead.
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
7 similar comments
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly, ensure that we only use
@_implementationOnlyif we build withRESILIENT_LIBRARIES.Also,
strerroris marked as unsafe and deprecated on Windows. It looks like this is becausestrerroris not thread-safe. Switch to the thread-safe versionstrerror_rinstead.