Parse InlineArray type sugar #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
inline-array-type
branch
2 times, most recently
from
9e0c4a8 to
27277c5
Compare
ahoppen
reviewed
Mar 18, 2025
hamishknight
force-pushed
the
inline-array-type
branch
from
27277c5 to
6393374
Compare
ahoppen
reviewed
Mar 18, 2025
This is handled in `parseType`, not `parseTypeScalar`. `canParseType` is currently the only client of `canParseTypeScalar` though, so this is NFC.
Parse e.g `[3 x Int]` as type sugar for InlineArray. Gated behind an experimental feature flag for now.
hamishknight
force-pushed
the
inline-array-type
branch
from
6393374 to
8a5bebf
Compare
ahoppen
approved these changes
Mar 18, 2025
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse e.g
[3 x Int]as type sugar for InlineArray. Gated behind an experimental feature flag for now.