Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ValueGenerics feature from swift-syntax #3022

Merged
merged 3 commits into from
Apr 1, 2025

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Mar 18, 2025

Now that the feature is always enabled, swiftlang/swift#79665, remove the need of the feature here.

@Azoy Azoy requested review from ahoppen and bnbarham as code owners March 18, 2025 20:31
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bnbarham
Copy link
Contributor

This will need a corresponding PR in swift to remove the mapping from .ValueGenerics -> .valueGenerics in SourceFile.swift

@Azoy
Copy link
Contributor Author

Azoy commented Mar 25, 2025

Corresponding swift PR here: swiftlang/swift#80277

@Azoy
Copy link
Contributor Author

Azoy commented Mar 25, 2025

Please test with following pull request:
swiftlang/swift#80277

@swift-ci please test

@Azoy Azoy force-pushed the remove-value-generic-feature branch from 949f1f7 to 13bfb9c Compare March 26, 2025 16:44
@Azoy
Copy link
Contributor Author

Azoy commented Mar 26, 2025

Please test with following pull request:
swiftlang/swift#80277

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Mar 26, 2025

Please test with following pull request:
swiftlang/swift#80277

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Apr 1, 2025

Please test with following pull request:
swiftlang/swift#80277
swiftlang/swift-format#974

@swift-ci please test

@bnbarham bnbarham merged commit c54a9d4 into swiftlang:main Apr 1, 2025
24 checks passed
@Azoy Azoy deleted the remove-value-generic-feature branch April 1, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants