Skip to content

[CI] Remove skip for ready for review #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented May 9, 2025

This unfortunately ends up causing CI checks to reset and always skipped after marking a PR ready for review.

This unfortunately ends up causing CI checks to reset and always skipped
after marking a PR ready for review.
@bnbarham bnbarham requested a review from ahoppen as a code owner May 9, 2025 19:43
@bnbarham
Copy link
Contributor Author

bnbarham commented May 9, 2025

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented May 12, 2025

@swift-ci Please test macOS

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also make the corresponding change in swift-format and update the template in https://github.com/swiftlang/github-workflows/blob/main/.github/workflows/create_automerge_pr.yml?

@bnbarham
Copy link
Contributor Author

@bnbarham bnbarham merged commit eda5e2f into swiftlang:main May 12, 2025
27 checks passed
@bnbarham bnbarham deleted the run-ci-on-ready branch May 12, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants